Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SUP-38407): [GaTech] [Multistream - V7 Player] Child entries not loading high quality flavor assets #851

Merged
merged 5 commits into from
Sep 15, 2024

Conversation

Tzipi-kaltura
Copy link
Contributor

@Tzipi-kaltura Tzipi-kaltura commented Sep 11, 2024

Description of the Changes

Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.

export changeChildQuality function

part of - https://github.com/kaltura/playkit-js/pull/793/files, kaltura/playkit-js-dual-screen#155

Resolves SUP-38407

Copy link
Contributor

@semarche-kaltura semarche-kaltura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix lint issues

@Tzipi-kaltura
Copy link
Contributor Author

fix lint issues

yes i need to merge first the playkit-js pull request so it will find the function.

@MosheMaorKaltura MosheMaorKaltura merged commit 0e9bd97 into master Sep 15, 2024
11 checks passed
Tzipi-kaltura added a commit to kaltura/playkit-js-dual-screen that referenced this pull request Sep 15, 2024
…loading high quality flavor assets (#155)

Issue:
Quality is not changed in childe entries when it is changed in the parent entry.

Fix:
Add listener to videotrackchange and change the quality manually to all the other entries.

part of - kaltura/playkit-js#793, kaltura/kaltura-player-js#851

solves SUP-38407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants